Skip to content

fix: increase retry period for validate_profile_deployments_with_custom_images#970

Merged
mvlassis merged 2 commits into
mainfrom
kf-8770-fix-flaky-test
Jul 1, 2026
Merged

fix: increase retry period for validate_profile_deployments_with_custom_images#970
mvlassis merged 2 commits into
mainfrom
kf-8770-fix-flaky-test

Conversation

@mvlassis

@mvlassis mvlassis commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Increase the timeout for the validate_profile_deployments_with_custom_images function to 90 seconds for both test_charm and test_charm_ambient

Notes

Because the metacontroller's resyncPeriodSeconds is 60 seconds, that means that it can theoretically take up to 60 seconds for the sync.py hook to be triggered. I added 30 seconds for buffer, since this won't affect successful runs

Closes #951

@ckfbot ckfbot added backport track/2.16 Backport to track/2.16 backport track/2.15 Backport to track/2.15 backport track/2.5 Backport to track/2.5 labels Jun 25, 2026
@ckfbot

ckfbot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🤖 Backport labels populated

Labels to this pull request were added automatically by the populate-labels.yaml action.

When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR.

@mvlassis mvlassis removed backport track/2.15 Backport to track/2.15 backport track/2.5 Backport to track/2.5 labels Jun 25, 2026
@mvlassis mvlassis force-pushed the kf-8770-fix-flaky-test branch from ecb7a00 to 890c3fa Compare July 1, 2026 12:59
@mvlassis mvlassis merged commit eedf043 into main Jul 1, 2026
227 of 250 checks passed
@mvlassis mvlassis deleted the kf-8770-fix-flaky-test branch July 1, 2026 15:44
@ckfbot

ckfbot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Created backport PR for track/2.16:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-970-to-track/2.16
git worktree add --checkout .worktree/backport-970-to-track/2.16 backport-970-to-track/2.16
cd .worktree/backport-970-to-track/2.16
git reset --hard HEAD^
git cherry-pick -x eedf043df7c620774a0f1df75639bc6ace33ee34

mvlassis added a commit that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport track/2.16 Backport to track/2.16

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambient test for test_change_custom_images is flaky

4 participants