fix: increase retry period for validate_profile_deployments_with_custom_images#970
Merged
Conversation
Contributor
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
MattiaSarti
approved these changes
Jun 25, 2026
NohaIhab
approved these changes
Jun 26, 2026
2165e28 to
d4b3907
Compare
ecb7a00 to
890c3fa
Compare
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-970-to-track/2.16
git worktree add --checkout .worktree/backport-970-to-track/2.16 backport-970-to-track/2.16
cd .worktree/backport-970-to-track/2.16
git reset --hard HEAD^
git cherry-pick -x eedf043df7c620774a0f1df75639bc6ace33ee34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_profile_deployments_with_custom_imagesfunction to 90 seconds for bothtest_charmandtest_charm_ambientNotes
Because the metacontroller's
resyncPeriodSecondsis 60 seconds, that means that it can theoretically take up to 60 seconds for thesync.pyhook to be triggered. I added 30 seconds for buffer, since this won't affect successful runsCloses #951